RFR: 8213177: GlobalCounter::CSContext could be an enum class [v2]

Kim Barrett kbarrett at openjdk.java.net
Wed Mar 10 19:20:10 UTC 2021


On Wed, 10 Mar 2021 18:57:12 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalCounter.hpp line 72:
>> 
>>> 70:   // critical_section_begin() to critical_section_end().
>>> 71:   enum class CSContext : uintx {}; // [COUNTER_ACTIVE, COUNTER_INCREMENT)
>>> 72: 
>> 
>> Please change the [ in the comment to a (
>
> Fixed

Those values are not a range!  One is a tag bit value, the other is the increment exclusive of the tag bit.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2895


More information about the hotspot-dev mailing list