RFR: 8213177: GlobalCounter::CSContext could be an enum class [v2]

Harold Seigel hseigel at openjdk.java.net
Wed Mar 10 19:20:11 UTC 2021


On Wed, 10 Mar 2021 19:02:12 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Harold Seigel has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix comments
>
> src/hotspot/share/utilities/globalCounter.hpp line 71:
> 
>> 69:   // The type of the critical section context passed from
>> 70:   // critical_section_begin() to critical_section_end().
>> 71:   enum class CSContext : uintx {}; // [COUNTER_ACTIVE, COUNTER_INCREMENT)
> 
> This enum declaration instead of the typedef is all that's needed.  The range comment is incorrect.

So, all this change needs is:  "enum class CSContext: uintx {};"   ?

-------------

PR: https://git.openjdk.java.net/jdk/pull/2895


More information about the hotspot-dev mailing list