RFR: 8213177: GlobalCounter::CSContext could be an enum class [v2]

Kim Barrett kbarrett at openjdk.java.net
Wed Mar 10 22:29:12 UTC 2021


On Wed, 10 Mar 2021 19:17:22 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> src/hotspot/share/utilities/globalCounter.hpp line 71:
>> 
>>> 69:   // The type of the critical section context passed from
>>> 70:   // critical_section_begin() to critical_section_end().
>>> 71:   enum class CSContext : uintx {}; // [COUNTER_ACTIVE, COUNTER_INCREMENT)
>> 
>> This enum declaration instead of the typedef is all that's needed.  The range comment is incorrect.
>
> So, all this change needs is:  "enum class CSContext: uintx {};"   ?

Yes.  The RFE was filed as a followup to JDK-8212827, where I did everything needed to make that work, but couldn't take that final step because we weren't supporting C++11/14 yet.

-------------

PR: https://git.openjdk.java.net/jdk/pull/2895


More information about the hotspot-dev mailing list