RFR: 8264126: Remove TRAPS/THREAD parameter for class loading functions [v3]

Coleen Phillimore coleenp at openjdk.java.net
Thu Mar 25 02:56:02 UTC 2021


> find_constrained_instance_or_array_klass only passes THREAD so that it can be used in a MutexLocker for SystemDictionary_lock. This can use the MutexLocker that gets Thread::current() without any harm to performance.
> 
> The other functions add_loader_constraint, record_linking_constraints, and check_signature_loaders fall out from that.
> 
> check_signature_loaders should throw an exception but it unfortunately makes the caller construct the exception message so it doesn't.
> 
> Also: is_shared_class_visible{_impl}
> 
> Tested with tier1 on 4 Oracle platforms (in progress)

Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:

  add back Thread parameter to find_constrained_instance_or_array_klass.

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/3176/files
  - new: https://git.openjdk.java.net/jdk/pull/3176/files/1e9e29cf..ca4d8cee

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=3176&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=3176&range=01-02

  Stats: 9 lines in 4 files changed: 1 ins; 0 del; 8 mod
  Patch: https://git.openjdk.java.net/jdk/pull/3176.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/3176/head:pull/3176

PR: https://git.openjdk.java.net/jdk/pull/3176


More information about the hotspot-dev mailing list