RFR: 8264538: Rename SystemDictionary::parse_stream [v2]

[Coleen Phillimore]

On Wed, 31 Mar 2021 20:22:08 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fifix comment
>
> src/hotspot/share/prims/jvmtiRedefineClasses.cpp line 1395:
> 
>> 1393:                                                       cl_info,
>> 1394:                                                       THREAD);
>> 1395: 
> 
> Could you add a comment above line 1390 saying you can't call resolve_class_from_stream() here because the resulting class should not go in the system dictionary?

// Parse and create a class from the bytes, but this class isn't added
    // to the dictionary, so do not call resolve_from_stream.

> src/hotspot/share/prims/jvmtiRedefineClasses.hpp line 305:
> 
>> 303: // - How do we serialize the RedefineClasses() API without deadlocking?
>> 304: //
>> 305: // - KlassFactory::create_from_stream() was called with a NULL protection
> 
> Maybe delete the comment that goes from lines 305 - 309 ?

Good idea.  The comment is really old and no longer relevant.

-------------

PR: https://git.openjdk.java.net/jdk/pull/3289