RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information [v4]

[Christian Hagedorn]

On Fri, 12 Nov 2021 20:40:07 GMT, Dean Long <dlong at openjdk.org> wrote:

>> The replay data was missing MethodData::_invocation_counter.  Adding it seems to fix the problem.  @rwestrel please verify if it works for you.  Also, with this change:
>> 1. added a version number to the replay file
>> 2. removed unnused ci fields
>> 3. corrected comment in TestLambdas.java
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   strengthen version check

> > I guess we could leave this in for old replay files with the initialization further down in ciReplay::initialize() if _version < 1.
> 
> Yes, it's necessary to parse the value for old replay files, but the value is never used. I'm not sure what you are suggesting about the initialization further down.

Ok, I was missing that the parsed value has no effect anyways. Then you do not need this code for the initialization on L1416 for `_version <  1`:

m->_current_mileage = rec->_current_mileage;


> > However, thinking again about this, it should not happen that we parse a version number that's not supported
> 
> A user could be using an older JDK but accidentally try a newer replay file. That was the scenario I had in mind.

That's a valid point for emitting a warning instead.

Changes look good to me!

-------------

Marked as reviewed by chagedorn (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/6344