RFR: 8276095: ciReplay: replay failure due to incomplete ciMethodData information [v4]

[Dean Long]

On Mon, 15 Nov 2021 12:56:35 GMT, Christian Hagedorn <chagedorn at openjdk.org> wrote:

>> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   strengthen version check
>
>> > I guess we could leave this in for old replay files with the initialization further down in ciReplay::initialize() if _version < 1.
>> 
>> Yes, it's necessary to parse the value for old replay files, but the value is never used. I'm not sure what you are suggesting about the initialization further down.
> 
> Ok, I was missing that the parsed value has no effect anyways. Then you do not need this code for the initialization on L1416 for `_version <  1`:
> 
> m->_current_mileage = rec->_current_mileage;
> 
> 
>> > However, thinking again about this, it should not happen that we parse a version number that's not supported
>> 
>> A user could be using an older JDK but accidentally try a newer replay file. That was the scenario I had in mind.
> 
> That's a valid point for emitting a warning instead.
> 
> Changes look good to me!

Thanks @chhagedorn and @vnkozlov.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6344