RFR: 8274986: max code printed in hs-err logs should be configurable [v4]
Doug Simon
dnsimon at openjdk.java.net
Tue Oct 12 07:34:22 UTC 2021
> This PR adds a `ErrorLogPrintCodeLimit` (develop) option for configuring the amount of code printed in a hs-err log file. There's a hard limit of 10 so that the buffer used to avoid duplicates in `VMError::print_code` is stack allocated.
> In addition, the Java stack is also scanned when considering code to print as the native stack may not have any Java compiled frames. For example, a transition into the VM through a RuntimeStub can prevent the native stack walk from seeing the frames above the stub.
> The MachCodeFramesInErrorFile test has been made more robust in terms of validating its expectations of how C2 intrinsifies methods.
>
> There's one other minor change to address [this comment](https://github.com/openjdk/jdk/pull/5446#issuecomment-938518814).
Doug Simon has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- print extra info for an nmethod in CodeBlob::dump_for_addr to st instead of tty in non-verbose mode
- made ErrorLogPrintCodeLimit a diagnostic flag
- make max code printed in hs-err log configurable and also scan Java stack for code to print
- do not unnecessarily pollute tty
-------------
Changes:
- all: https://git.openjdk.java.net/jdk/pull/5875/files
- new: https://git.openjdk.java.net/jdk/pull/5875/files/feb40153..83e6abd4
Webrevs:
- full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5875&range=03
- incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5875&range=02-03
Stats: 835 lines in 73 files changed: 346 ins; 247 del; 242 mod
Patch: https://git.openjdk.java.net/jdk/pull/5875.diff
Fetch: git fetch https://git.openjdk.java.net/jdk pull/5875/head:pull/5875
PR: https://git.openjdk.java.net/jdk/pull/5875
More information about the hotspot-dev
mailing list