RFR: 8274179: AArch64: Support SVE operations with encodable immediates [v3]

Fei Gao duke at openjdk.java.net
Thu Oct 28 10:43:34 UTC 2021


On Tue, 26 Oct 2021 09:38:38 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Fei Gao has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision:
>> 
>>  - Split the original patch and leave the existing logic in Assembler entirely untouched
>>    
>>    Change-Id: If8ddcef07b15615d7dd0c3063c44d2b705fac6f7
>>  - Merge branch 'master' of github.com:fg1417/jdk into fg1417-20211026
>>    
>>    Change-Id: I52aa66d200b74ac312c5d40283b94854bc1142e6
>
> src/hotspot/cpu/aarch64/aarch64.ad line 2669:
> 
>> 2667:   if (!imm_node->is_Con() ||
>> 2668:       !(imm_node->bottom_type()->isa_int() || imm_node->bottom_type()->isa_long())) {
>> 2669:     return false;
> 
> I'd split this up a bit.
> 
> Please consider
> 
> 
> if (!imm_node->is_Con()  return false;
> 
> const Type t = imm_node->bottom_type();
> if (! (t->isa_int() || t->isa_long))  return false;

Done

-------------

PR: https://git.openjdk.java.net/jdk/pull/6115


More information about the hotspot-dev mailing list