RFR: 8137018: [JVMCI] Encapsulate new Thread fields for JVMCI

[David Holmes]

On Wed, 1 Sep 2021 18:03:11 GMT, Tom Rodriguez <never at openjdk.org> wrote:

> This evacuates all JVMCI related methods and fields into a separately declared struct.

Nice refactoring!

A few style nits but nothing of consequence.

Thanks,
David

src/hotspot/share/jvmci/jvmci.cpp line 405:

> 403: }
> 404: 
> 405: 

Nit: there are a few double-blank lines between definitions when one is normal.

src/hotspot/share/jvmci/jvmci.hpp line 198:

> 196: 
> 197:   // Communicates the DeoptReason and DeoptAction of the uncommon trap
> 198:   int       _pending_deoptimization;

Nit: Why the extra large alignment spacing of all the declarations? (I'm not a fan of such alignment as it is too hard to maintain - and too hard to type in the first place!)

src/hotspot/share/jvmci/jvmci.hpp line 249:

> 247:   void set_jvmci_reserved_oop0(oop value) {
> 248:     _jvmci_reserved_oop0 = value;
> 249:   }

Nit: why is this and following definitions multi-line when the preceding ones (of similar size) are single line?

-------------

Marked as reviewed by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5339