RFR: 8264207: CodeStrings does not honour fixed address assumption.
David Holmes
david.holmes at oracle.com
Fri Sep 3 11:49:58 UTC 2021
On 3/09/2021 6:19 pm, Patric Hedlin wrote:
> On Fri, 3 Sep 2021 06:43:30 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
>
>> src/hotspot/share/asm/codeBuffer.hpp line 284:
>>
>>> 282: // the generated assembly code are unique, i.e. there is very little gain in
>>> 283: // trying to share the strings between the different offsets tracked in a
>>> 284: // buffer (or blob).
>>
>> Noticed some double whitespaces in many of the code comments, for example "assembly__code", "different__offsets".
>
> Comments are (fully) justified for readability (within limits, not using hyphenation), same as text in books, newspapers and reports.
It is not at all usual to justify comments in this way, and not part of
the hotspot style. I would also imagine it is very tedious to write them
like that.
Cheers,
David
-----
> -------------
>
> PR: https://git.openjdk.java.net/jdk/pull/5281
>
More information about the hotspot-dev
mailing list