RFR: 8264207: CodeStrings does not honour fixed address assumption.

[Tobias Hartmann]

On Fri, 3 Sep 2021 08:16:07 GMT, Patric Hedlin <phedlin at openjdk.org> wrote:

>> src/hotspot/share/asm/codeBuffer.hpp line 284:
>> 
>>> 282: // the generated assembly  code are unique, i.e. there is  very little gain in
>>> 283: // trying to  share the  strings between  the different  offsets tracked  in a
>>> 284: // buffer (or blob).
>> 
>> Noticed some double whitespaces in many of the code comments, for example "assembly__code", "different__offsets".
>
> Comments are (fully) justified for readability (within limits, not using hyphenation), same as text in books, newspapers and reports.

As we discussed off-thread, I would prefer to not manually enforce block text layout by inserting extra whitespace because it is tedious and increases the burden on anyone later modifying (parts of) that comment.

Although I do understand that this layout might be easier to read for some people, I think it's the IDE's responsibility to display the comment in the user preferred way. If at all, line length restrictions and such should be part of the HotSpot Style Guide to guarantee consistency.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5281