RFR: 8137018: [JVMCI] Encapsulate new Thread fields for JVMCI [v2]

Tom Rodriguez never at openjdk.java.net
Fri Sep 3 20:02:43 UTC 2021


On Thu, 2 Sep 2021 04:22:00 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Tom Rodriguez has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review cleanups
>
> src/hotspot/share/jvmci/jvmci.cpp line 405:
> 
>> 403: }
>> 404: 
>> 405: 
> 
> Nit: there are a few double-blank lines between definitions when one is normal.

fixed.

> src/hotspot/share/jvmci/jvmci.hpp line 249:
> 
>> 247:   void set_jvmci_reserved_oop0(oop value) {
>> 248:     _jvmci_reserved_oop0 = value;
>> 249:   }
> 
> Nit: why is this and following definitions multi-line when the preceding ones (of similar size) are single line?

I've flattened them out.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5339


More information about the hotspot-dev mailing list