RFR: 8137018: [JVMCI] Encapsulate new Thread fields for JVMCI [v2]

Tom Rodriguez never at openjdk.java.net
Fri Sep 3 20:02:49 UTC 2021


On Thu, 2 Sep 2021 13:41:24 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> src/hotspot/share/jvmci/jvmci.hpp line 198:
>> 
>>> 196: 
>>> 197:   // Communicates the DeoptReason and DeoptAction of the uncommon trap
>>> 198:   int       _pending_deoptimization;
>> 
>> Nit: Why the extra large alignment spacing of all the declarations? (I'm not a fan of such alignment as it is too hard to maintain - and too hard to type in the first place!)
>
> That probably comes from a time before we nicely commented each JVMCI field ;-)
> I agree that there's no need for the alignment now.

I removed the extra indenting.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5339


More information about the hotspot-dev mailing list