RFR: JDK-8272771: frame::pd_ps() is not implemented on any platform

Aleksey Shipilev shade at openjdk.java.net
Mon Sep 13 08:23:54 UTC 2021


On Mon, 13 Sep 2021 08:01:26 GMT, Tobias Holenstein <github.com+71546117+tobiasholenstein at openjdk.org> wrote:

> removed frame::pd_ps() which is not implemented on any platform. Replaced the only usage of frame::pd_ps() in the debug function `ps()` with `frame::print_on`. Tested on Tier1.
> 
> Thanks!

I am confused a bit. I don't see any platform where `pd_ps` is not empty (I see that it was implemented for now-removed SPARC port), so the compatible thing would be to remove the call to `pd_ps` completely? From a brief inspection, I suspect that `p->trace_stack_from` handles the printing here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5487


More information about the hotspot-dev mailing list