RFR: JDK-8272771: frame::pd_ps() is not implemented on any platform

[David Holmes]

On Mon, 13 Sep 2021 08:01:26 GMT, Tobias Holenstein <github.com+71546117+tobiasholenstein at openjdk.org> wrote:

> removed frame::pd_ps() which is not implemented on any platform. Replaced the only usage of frame::pd_ps() in the debug function `ps()` with `frame::print_on`. Tested on Tier1.
> 
> Thanks!

Hi Tobias,

Removal looks good, but one change requested.

Thanks,
David

src/hotspot/share/utilities/debug.cpp line 514:

> 512:     tty->print("(guessing starting frame id=" PTR_FORMAT " based on current fp)\n", p2i(f.id()));
> 513:     p->trace_stack_from(vframe::new_vframe(&f, &reg_map, p));
> 514:     f.print_on(tty);

I agree with @shipilev - as pd_ps() was a no-op on all platforms it should simply be deleted from this code, not replaced by `f.print_on`.

-------------

Changes requested by dholmes (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/5487