RFR: JDK-8272771: frame::pd_ps() is not implemented on any platform [v2]

Tobias Holenstein github.com+71546117+tobiasholenstein at openjdk.java.net
Tue Sep 14 07:10:13 UTC 2021


On Tue, 14 Sep 2021 02:30:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   JDK-8272771: removed call to print_on() in debug::ps()
>
> src/hotspot/share/utilities/debug.cpp line 514:
> 
>> 512:     tty->print("(guessing starting frame id=" PTR_FORMAT " based on current fp)\n", p2i(f.id()));
>> 513:     p->trace_stack_from(vframe::new_vframe(&f, &reg_map, p));
>> 514:     f.print_on(tty);
> 
> I agree with @shipilev - as pd_ps() was a no-op on all platforms it should simply be deleted from this code, not replaced by `f.print_on`.

you are right -  I removed the call to `f.print_on(tty)` now. Thanks!

-------------

PR: https://git.openjdk.java.net/jdk/pull/5487


More information about the hotspot-dev mailing list