RFR: JDK-8271567: AArch64: AES Galois CounterMode (GCM) interleaved implementation using vector instructions [v8]

Andrew Haley aph at openjdk.java.net
Tue Sep 14 14:37:06 UTC 2021


On Mon, 13 Sep 2021 12:28:47 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Whitespace
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64_aes.cpp line 604:
> 
>> 602:   // v4: high part of product
>> 603:   // v5: low part ...
>> 604:   //
> 
> I'm not clear about this comment. The ghash generators have a stride of 7. Should this not mean the registers are replicated across v0 - v27 with v6, v13, v20 and v27 classified as unused registers.

Well spotted.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5390


More information about the hotspot-dev mailing list