RFR: 8282528: AArch64: Incorrect replicate2L_zero rule [v2]
Andrew Haley
aph at openjdk.java.net
Mon Apr 11 12:41:40 UTC 2022
On Mon, 11 Apr 2022 12:24:37 GMT, Eric Liu <eliu at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/aarch64_neon_ad.m4 line 1571:
>>
>>> 1569: `$3 $4', `I _imm', ` '$con$$constant,
>>> 1570: `$3 $4', `L _imm', ` '$con$$constant,
>>> 1571: `$6', vRegF,`
>>
>> This `ifelse` is rather confusing. Can't the '& 0xff' be passed as arguments into `VREPLICATE`?
>
> Done. I think these rules should not have been merged by force. It's hard to maintain.
It doesn't look too awful. Having said that, if I were you I'd get rid of all the `ifelse` expressions triggered by empty args.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7939
More information about the hotspot-dev
mailing list