RFR: 8284274: Error reporting crashes because missing ResourceMarks [v2]

[Coleen Phillimore]

On Tue, 12 Apr 2022 16:17:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Taking the suggestion from @stefank in the bug report, disable the ResourceMark missing assert during error reporting.  There's a ResourceArea in the thread that can be used.  Added a test.
>> Tested with tier1-4 on x86 and aarch64 platforms.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add some variable names for test values.

Thanks Thomas for reviewing this.  I had a theory why we would see a missing ResourceMark in a loom stack trace (StackFrameStream?) but didn't have a reproducer for it.  It seems better to suppress this assert completely during error reporting.  If a resource allocation is used with no current thread, that would be a different crash.  I agree, we should try to avoid any allocation during hs_err file production but sometimes these resource allocations sneak in a lower level, so better to let them go. I'm surprised we don't get more asserts from ResourceMark.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8201