RFR: 8284274: Error reporting crashes because missing ResourceMarks [v2]

[Thomas Stuefe]

On Tue, 12 Apr 2022 19:46:37 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

> Thanks Thomas for reviewing this. I had a theory why we would see a missing ResourceMark in a loom stack trace (StackFrameStream?) but didn't have a reproducer for it. It seems better to suppress this assert completely during error reporting. 

I agree.

> If a resource allocation is used with no current thread, that would be a different crash. I agree, we should try to avoid any allocation during hs_err file production but sometimes these resource allocations sneak in a lower level, so better to let them go. I'm surprised we don't get more asserts from ResourceMark.

At SAP we rely a lot on hs-err files, and fixing secondary errors is something we did a lot. For a while, we had even tests for that and really tried to keep up, fixing every instance. But I think we gave up on that, since it bitrots too fast.

Thank you for that fix!

Cheers, Thomas

-------------

PR: https://git.openjdk.java.net/jdk/pull/8201