RFR: 8242440: use separate, destroyable JavaVM instances per libgraal compiler thread
David Holmes
dholmes at openjdk.java.net
Sun Apr 17 02:28:35 UTC 2022
On Fri, 15 Apr 2022 13:29:43 GMT, Doug Simon <dnsimon at openjdk.org> wrote:
> Currently, libgraal runs in a single, permanent JavaVM instance loaded from libjvmcicompiler.so. This poses 2 problems:
>
> 1. The memory used for libgraal is never released, even when the libgraal compiler queues are idle.
> 2. Since all libgraal HotSpot compiler threads share the same SVM heap, libgraal compilation is effectively paused when a GC occurs (SVM currently has a stop the world collector). The more compiler threads there are, the more often this happens.
>
> This PR implements the following solution to these problems:
> 1. Create a new JavaVM instance per libgraal compiler thread (i.e. a separate SVM isolate per thread). This prevents GC in one libgraal thread from impacting another libgraal thread.
> 2. Destroy the JavaVM instances when a libgraal compiler thread becomes idle and create a new one when subsequent compilation requests arrive.
>
> Most of the changes are in JVMCI specific files. The most significant change to shared code is the addition of the `JavaThread:: _libjvmci_runtime` field. This is required as any thread (not just a `CompilerThread`) can be associated with a specific `JVMCIRuntime` object.
src/hotspot/share/compiler/abstractCompiler.hpp line 170:
> 168: // Notifies this compiler that the current thread (`thread`) is about to stop.
> 169: // The current thread currently holds the CompileThread_lock.
> 170: virtual void stopping_compiler_thread(CompilerThread* thread) {
If `thread` is the current thread then I'd recommend calling it `current` so that this is clear.
-------------
PR: https://git.openjdk.java.net/jdk/pull/8262
More information about the hotspot-dev
mailing list