RFR: 8242440: use separate, destroyable JavaVM instances per libgraal compiler thread [v2]
Doug Simon
dnsimon at openjdk.java.net
Tue Apr 19 10:11:05 UTC 2022
On Sun, 17 Apr 2022 02:25:40 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> Doug Simon has updated the pull request incrementally with six additional commits since the last revision:
>>
>> - avoid use of jobject for oop handles implementing foreign object references in libjvmci heap to HotSpot heap objects
>> - inlined JVMCIRuntime::_jobjects
>> - replace NULL with nullptr
>> - added JVMCIRuntime_lock global
>> - replace enum with const definition
>> - rename thread parameter to current
>
> src/hotspot/share/compiler/abstractCompiler.hpp line 170:
>
>> 168: // Notifies this compiler that the current thread (`thread`) is about to stop.
>> 169: // The current thread currently holds the CompileThread_lock.
>> 170: virtual void stopping_compiler_thread(CompilerThread* thread) {
>
> If `thread` is the current thread then I'd recommend calling it `current` so that this is clear.
Fixed: https://github.com/openjdk/jdk/pull/8262/commits/f448c2f6f859aea772a748458cbd336a8744afed
-------------
PR: https://git.openjdk.java.net/jdk/pull/8262
More information about the hotspot-dev
mailing list