RFR: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities [v4]

Nick Gasson ngasson at openjdk.java.net
Thu Apr 28 15:18:44 UTC 2022


On Thu, 28 Apr 2022 12:38:20 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> In a few places we pass offsets as 32-bit ints rather than 64-bit longs, and we're not consistent about it. We shold have a clean 64-bit path for offset generation and validation.
>
> Andrew Haley has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Windows!

Seems fine. Was this fixing a particular issue?

src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 6524:

> 6522: 
> 6523:     // lr and fp are already in place
> 6524:     __ sub(sp, rfp, ((uint64_t)framesize-4) << LogBytesPerInt); // prolog

Typo prolog -> prologue in the existing code.

-------------

Marked as reviewed by ngasson (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8448


More information about the hotspot-dev mailing list