RFR: 8285802: AArch64: Consistently handle offsets in MacroAssembler as 64-bit quantities [v4]

Andrew Haley aph at openjdk.java.net
Thu Apr 28 16:43:41 UTC 2022


On Thu, 28 Apr 2022 15:15:21 GMT, Nick Gasson <ngasson at openjdk.org> wrote:

> Seems fine. Was this fixing a particular issue?

It's a latent bug. I don't think it manifests today, but it's a bug.

> src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp line 6524:
> 
>> 6522: 
>> 6523:     // lr and fp are already in place
>> 6524:     __ sub(sp, rfp, ((uint64_t)framesize-4) << LogBytesPerInt); // prolog
> 
> Typo prolog -> prologue in the existing code.

I think that "prolog" is a correct variant of "prologue" in American English.

-------------

PR: https://git.openjdk.java.net/jdk/pull/8448


More information about the hotspot-dev mailing list