Integrated: 8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)

[Harold Seigel]

On Thu, 4 Aug 2022 14:29:23 GMT, Harold Seigel <hseigel at openjdk.org> wrote:

> The JVM fails when generating oop maps for method getAlphanumericCode(int) in bug_file/com/google/zxing/qrcode/encoder/Encoder.javap because the last bytecode in the method is an unreachable conditional branch at byecode index 11131:
> 
>       11124: ireturn
>       11125: iinc          41, 1
>       11128: iload         41
>       11130: iconst_2
>       11131: if_icmple     291
> 
> The class file (Encoder.class) containing getAlphanumericCode(int) has a class file version of 49.  So it is verified by the old verifier, which allows methods to end in a conditional branch provided that the conditional branch is unreachable during method execution.
> 
> This fix changes GenerateOopMap::jump_targets_do() to handle such methods.
> 
> The fix was tested by running the user's failing program, the new regression test, Mach5 tiers 1-2 on Linux, Mac OS, and Windows, Mach5 tiers 3-5 on Linu x64, and the JC Lang,VM, and API tests locally on Linux x64.
> 
> Please review.
> Thanks, Harold

This pull request has now been integrated.

Changeset: 8d88be23
Author:    Harold Seigel <hseigel at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/8d88be233bc0d27d78e51c4eff0ba1ee47f4617a
Stats:     115 lines in 3 files changed: 114 ins; 0 del; 1 mod

8291459: JVM crash with GenerateOopMap::error_work(char const*, __va_list_tag*)

Reviewed-by: dholmes, coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/9745