RFR: 8292007: Do not include vmSymbol.hpp in method.hpp [v2]

Ioi Lam iklam at openjdk.org
Tue Aug 9 20:11:11 UTC 2022


> A small build speed improvement:
> 
> The popular header method.hpp has this inline function
> 
> 
> bool is_continuation_enter_intrinsic() const {
>   return intrinsic_id() == vmIntrinsics::_Continuation_enterSpecial;
> }
> 
> 
> which causes the large header files vmSymbols.hpp and vmIntrinsics.hpp to be unnecessarily included by many HotSpot object files.
> 
> The fix is to move this function to method.inline.hpp.
> 
> (It might be performance critical since it's used by some loops that walk the call frames).

Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' of https://github.com/openjdk/jdk into 8292007-dont-include-vmSymbol-in-method-hpp
 - 8292007: Do not include vmSymbol.hpp in method.hpp

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/9789/files
  - new: https://git.openjdk.org/jdk/pull/9789/files/65363ee9..ef6fd477

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=9789&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=9789&range=00-01

  Stats: 2460 lines in 105 files changed: 1652 ins; 520 del; 288 mod
  Patch: https://git.openjdk.org/jdk/pull/9789.diff
  Fetch: git fetch https://git.openjdk.org/jdk pull/9789/head:pull/9789

PR: https://git.openjdk.org/jdk/pull/9789


More information about the hotspot-dev mailing list