RFR: 8292007: Do not include vmSymbol.hpp in method.hpp [v2]

Thomas Stuefe stuefe at openjdk.org
Wed Aug 10 04:58:36 UTC 2022


On Tue, 9 Aug 2022 20:11:11 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> A small build speed improvement:
>> 
>> The popular header method.hpp has this inline function
>> 
>> 
>> bool is_continuation_enter_intrinsic() const {
>>   return intrinsic_id() == vmIntrinsics::_Continuation_enterSpecial;
>> }
>> 
>> 
>> which causes the large header files vmSymbols.hpp and vmIntrinsics.hpp to be unnecessarily included by many HotSpot object files.
>> 
>> The fix is to move this function to method.inline.hpp.
>> 
>> (It might be performance critical since it's used by some loops that walk the call frames).
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8292007-dont-include-vmSymbol-in-method-hpp
>  - 8292007: Do not include vmSymbol.hpp in method.hpp

All good.

-------------

PR: https://git.openjdk.org/jdk/pull/9789


More information about the hotspot-dev mailing list