Integrated: 8292007: Do not include vmSymbol.hpp in method.hpp

Ioi Lam iklam at openjdk.org
Wed Aug 10 03:02:39 UTC 2022


On Sat, 6 Aug 2022 02:04:42 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> A small build speed improvement:
> 
> The popular header method.hpp has this inline function
> 
> 
> bool is_continuation_enter_intrinsic() const {
>   return intrinsic_id() == vmIntrinsics::_Continuation_enterSpecial;
> }
> 
> 
> which causes the large header files vmSymbols.hpp and vmIntrinsics.hpp to be unnecessarily included by many HotSpot object files.
> 
> The fix is to move this function to method.inline.hpp.
> 
> (It might be performance critical since it's used by some loops that walk the call frames).

This pull request has now been integrated.

Changeset: 49133809
Author:    Ioi Lam <iklam at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/49133809c2331a8a2067228adceb1d6e97cb19a8
Stats:     25 lines in 13 files changed: 18 ins; 2 del; 5 mod

8292007: Do not include vmSymbol.hpp in method.hpp

Reviewed-by: coleenp

-------------

PR: https://git.openjdk.org/jdk/pull/9789


More information about the hotspot-dev mailing list