RFR: 8292218: Convert PackageEntryTable to ResourceHashtable [v2]

[Coleen Phillimore]

On Thu, 11 Aug 2022 16:09:06 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:

>> src/hotspot/share/classfile/packageEntry.cpp line 202:
>> 
>>> 200:         log_info(module, unload)("unloading package %s", str);
>>> 201:         log_debug(module)("PackageEntry: deleting module: %s", str);
>>> 202:       }
>> 
>> Not "deleting module" but "deleting package"
>
> And maybe these logging comments are more appropriately placed in ~PackageEntry?

I fixed the message.  I liked this idea but when I tried to move this one and the similar one in module (so that they're the same), I had two problems.  The module's name can be null in the destructor (for the unnamed module) so the logging statement crashed so would need more conditionals.  For package entries, there's a put_if_absent() so I have a destructor call for the case that the entry isn't absent, which would then log that it had been unloaded.  So that would have been bad.  So I moved it and then back to where it started.

-------------

PR: https://git.openjdk.org/jdk/pull/9837