RFR: 8292218: Convert PackageEntryTable to ResourceHashtable [v2]
Coleen Phillimore
coleenp at openjdk.org
Thu Aug 11 19:15:53 UTC 2022
On Thu, 11 Aug 2022 16:11:21 GMT, Lois Foltan <lfoltan at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix debug info and module name comparison.
>
> src/hotspot/share/classfile/packageEntry.cpp line 283:
>
>> 281: int n = 0;
>> 282: auto count = [&] (const Symbol*& key, PackageEntry*& p) {
>> 283: if (p->module()->name() != NULL) {
>
> The better way to check for the unnamed module is to use the ModuleEntry::is_named() method.
Fixed.
> src/hotspot/share/classfile/packageEntry.cpp line 293:
>
>> 291: n = 0;
>> 292: auto grab = [&] (const Symbol*& key, PackageEntry*& p) {
>> 293: if (p->module()->name() != NULL) {
>
> The better way to check for the unnamed module is to use the ModuleEntry::is_named() method
Fixed.
-------------
PR: https://git.openjdk.org/jdk/pull/9837
More information about the hotspot-dev
mailing list