RFR: 8292016: Rework JLI_ReportErrorMessageSys [v10]

[David Holmes]

On Tue, 16 Aug 2022 10:23:31 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Second attempt at resolving [JDK-8292016](https://bugs.openjdk.org/browse/JDK-8292016) with a less intrusive approach this time 
>> 
>> Side note: While it might be preferred to remove this entirely, other areas of the JDK also use the same flawed logic, and removing this would simply push the issue elsewhere. Fixing this might result in a solution which can be used in those areas in the future.
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Cleanup

src/java.base/unix/native/libjli/java_md_common.c line 213:

> 211:          */
> 212:         char error[1024];
> 213:         if(strerror_r(errno, error, sizeof error) == 0) {

Style nit: need space after 'if'

This applies to other files too.

src/java.base/windows/native/libjli/java_md.c line 621:

> 619:     char  *errtext = NULL;
> 620: 
> 621:     char* const conflict = "Java detected conflicting Windows and C Runtime errors and is unable to provide an accurate report";

So why not report both of them as part of the message?

-------------

PR: https://git.openjdk.org/jdk/pull/9870