RFR: 8292016: Rework JLI_ReportErrorMessageSys [v10]

Julian Waters jwaters at openjdk.org
Thu Aug 18 08:14:18 UTC 2022


On Thu, 18 Aug 2022 02:39:55 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Cleanup
>
> src/java.base/windows/native/libjli/java_md.c line 621:
> 
>> 619:     char  *errtext = NULL;
>> 620: 
>> 621:     char* const conflict = "Java detected conflicting Windows and C Runtime errors and is unable to provide an accurate report";
> 
> So why not report both of them as part of the message?

I was mainly concerned with Thomas's objection that having both would simply be misleading, though now that you say that, maybe this warning combined with both could be a good compromise.

@tstuefe thoughts?

-------------

PR: https://git.openjdk.org/jdk/pull/9870


More information about the hotspot-dev mailing list