RFR: 8290075: [JVMCI] only blessed methods can link against EventWriterFactory.getEventWriter [v3]

Markus Grönlund mgronlun at openjdk.org
Mon Aug 22 17:29:35 UTC 2022


On Mon, 22 Aug 2022 16:48:53 GMT, Doug Simon <dnsimon at openjdk.org> wrote:

>> I think we want to test what is being shipped. From the beginning there was --add-exports, but then it was removed and we found issues (unexpected exception). Maybe we can have both, but I think it would be unfortunate to not test the "full scenario" (which might include registering an event).
>
> As far as I can see, without the `--add-exports`, all that is being tested is module access checks. Are there other tests specifically testing the access checks in [`JfrResolution::on_runtime_resolution`](https://github.com/openjdk/jdk/blob/aa9b8f04bf74d5fa00f2b27895e7369abea3a930/src/hotspot/share/jfr/instrumentation/jfrResolution.cpp#L55).
> That said, I'm happy to leave the original tests in `TestGetEventWriter.java` as is.

Ok Douglas, please leave the original tests as is. There are a few paths involved, and we need to remember why we ended up stating the tests as we did. We can revisit this later, so let's not block you from getting this in.

-------------

PR: https://git.openjdk.org/jdk/pull/9449


More information about the hotspot-dev mailing list