RFR: 8292891: ifdef-out some CDS-only functions [v2]

[Coleen Phillimore]

On Thu, 25 Aug 2022 06:18:36 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Some CDS functions are always compiled, even when CDS is not enabled (e.g., for the minimal VM).
>> 
>> This RFE puts some of the obvious ones inside `#if INCLUDE_CDS` blocks. 
>> 
>> Note: my goal is not to make the minimal VM as small as possible. But rather, I don't want to put `#if INCLUDE_CDS` inside each of those functions that access a CDS-only feature. (E.g., `ConstantPoolCache::save_for_archive`, which accesses `_initial_entries`, which is declared only when CDS is enabled).
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @calvinccheung comments

src/hotspot/share/oops/klass.hpp line 575:

> 573:     }
> 574:   }
> 575: #endif

Can you add an // INCLUDE_CDS here?  If they're more than 10 lines apart, uncommented endifs can be really confusing.  This one is sort of borderline far away.  Thanks.

-------------

PR: https://git.openjdk.org/jdk/pull/10010