RFR: 8157023: Integrate NMT with JFR [v3]
Stefan Johansson
sjohanss at openjdk.org
Tue Dec 6 13:36:06 UTC 2022
On Tue, 6 Dec 2022 12:53:31 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:
>> Stefan Johansson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Special snapshot for NMT events in JFR
>
> src/hotspot/share/services/memSnapshot.cpp line 99:
>
>> 97: if (_snapshot_options.update_thread_stacks) {
>> 98: walk_thread_stacks();
>> 99: }
>
> It does not make sense to walk_thread_stacks independently from the VM snapshot, since it piggy-backs on it. I would move this into the _snapshot_options.include_vm condition.
True and this is why I kind of think malloc and vm should not be optional. But I can move this into the "vm" condition.
-------------
PR: https://git.openjdk.org/jdk/pull/11449
More information about the hotspot-dev
mailing list