RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

Coleen Phillimore coleenp at openjdk.org
Mon Dec 12 18:02:59 UTC 2022


On Thu, 8 Dec 2022 16:56:40 GMT, Afshin Zafari <duke at openjdk.org> wrote:

>> test of tier1-5 passed.
>
> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8292741: Convert JvmtiTagMapTable to ResourceHashtable

I have a couple of minor comments but this looks good.  This hashtable was more problematic to convert so good job!

src/hotspot/share/prims/jvmtiTagMapTable.cpp line 117:

> 115: JvmtiTagMapEntry* JvmtiTagMapTable::find(oop obj) {
> 116:   if (obj->fast_no_hash_check()) {
> 117:     // Objects in the table all have a hashcode.

Can you keep this comment?

src/hotspot/share/prims/jvmtiTagMapTable.hpp line 72:

> 70: typedef
> 71: ResizeableResourceHashtable <JvmtiTagMapKey, jlong,
> 72:                               AnyObj::C_HEAP, mtInternal,

This should be mtServiceability rather than mtInternal.

-------------

Marked as reviewed by coleenp (Reviewer).

PR: https://git.openjdk.org/jdk/pull/11288


More information about the hotspot-dev mailing list