RFR: 8292741: Convert JvmtiTagMapTable to ResourceHashtable [v7]

Afshin Zafari duke at openjdk.org
Wed Dec 14 13:16:03 UTC 2022


On Mon, 12 Dec 2022 17:58:53 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8292741: Convert JvmtiTagMapTable to ResourceHashtable
>
> src/hotspot/share/prims/jvmtiTagMapTable.cpp line 117:
> 
>> 115: JvmtiTagMapEntry* JvmtiTagMapTable::find(oop obj) {
>> 116:   if (obj->fast_no_hash_check()) {
>> 117:     // Objects in the table all have a hashcode.
> 
> Can you keep this comment?

Done

> src/hotspot/share/prims/jvmtiTagMapTable.hpp line 72:
> 
>> 70: typedef
>> 71: ResizeableResourceHashtable <JvmtiTagMapKey, jlong,
>> 72:                               AnyObj::C_HEAP, mtInternal,
> 
> This should be mtServiceability rather than mtInternal.

Done

-------------

PR: https://git.openjdk.org/jdk/pull/11288


More information about the hotspot-dev mailing list