[jdk20] RFR: 8298084: Memory leak in Method::build_profiling_method_data [v6]

[Justin King]

On Tue, 13 Dec 2022 02:44:44 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change fixes the MethodData leak by calling the destructor in both the release_C_heap_structures conditionally and by calling the MethodData destructor in the MetadataFactory::free_metadata method.
>> Thanks to @jcking for working on the patch and discussion.
>> Tested with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Even more comment updates.  Removed word salad.

Marked as reviewed by jcking (Author).

src/hotspot/share/memory/metadataFactory.hpp line 76:

> 74:       // that needs to be destructed to release resources. Most Metadata derived classes have noop
> 75:       // destructors and/or cleanup using deallocate_contents.
> 76:       // T is a potentially const or volatile qualified pointer. Remove any const

We'll given the template, T by itself is no longer a pointer so its just potentially const or volatile qualified. But that is pedantic.

-------------

PR: https://git.openjdk.org/jdk20/pull/13