[jdk20] RFR: 8298084: Memory leak in Method::build_profiling_method_data [v6]

Coleen Phillimore coleenp at openjdk.org
Tue Dec 13 13:04:21 UTC 2022


On Tue, 13 Dec 2022 03:31:32 GMT, Justin King <jcking at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Even more comment updates.  Removed word salad.
>
> src/hotspot/share/memory/metadataFactory.hpp line 76:
> 
>> 74:       // that needs to be destructed to release resources. Most Metadata derived classes have noop
>> 75:       // destructors and/or cleanup using deallocate_contents.
>> 76:       // T is a potentially const or volatile qualified pointer. Remove any const
> 
> We'll given the template, T by itself is no longer a pointer so its just potentially const or volatile qualified. But that is pedantic.

I just want to leave it because you're right but pointer is a readable noun here.

-------------

PR: https://git.openjdk.org/jdk20/pull/13


More information about the hotspot-dev mailing list