RFR: 8282306: os::is_first_C_frame(frame*) crashes on invalid link access [v2]

[David Holmes]

On Wed, 23 Feb 2022 21:35:53 GMT, Johannes Bechberger <duke at openjdk.java.net> wrote:

>> src/hotspot/share/utilities/vmError.cpp line 338:
>> 
>>> 336:       // is_first_C_frame() does only simple checks for frame pointer,
>>> 337:       // it will pass if java compiled code has a pointer in EBP.
>>> 338:       if (os::is_first_C_frame(&fr, t)) return invalid;
>> 
>> Is the comment still accurate?
>
> I think so? But maybe removing the second line would be helpful.

But are the checks still "simple"?

-------------

PR: https://git.openjdk.java.net/jdk/pull/7591