RFR: JDK-8278329: some TraceDeoptimization code not included in PRODUCT build [v3]

[Tobias Holenstein]

On Fri, 7 Jan 2022 10:56:36 GMT, Tobias Holenstein <duke at openjdk.java.net> wrote:

>> After "JDK-8154011: Make `TraceDeoptimization` a diagnostic flag" some code was not included in the PRODUCT build. 
>> 
>> Removed all the #ifndef PRODUCT guards around `TraceDeoptimization` checks and made sure to be consistent. 
>> 
>> The DEOPT PACKING messages were controlled by `PrintDeoptimizationDetails` (develop flag), but DEOPT UNPACKING is controlled by `TraceDeoptimization` (product flag),. Therefore changed DEOPT PACKING messages to be controlled by `TraceDeoptimization` as well. 
>> 
>> Checked that tests are not affected. Checked on Aurora that performance is not affected.
>
> Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> 
>   minor style issues

> _Mailing list message from [David Holmes](mailto:david.holmes at oracle.com) on [hotspot-dev](mailto:hotspot-dev at mail.openjdk.java.net):_
> 
> Hi Tobias,
> 
> On 7/01/2022 8:56 pm, Tobias Holenstein wrote:
> 
> > On Fri, 7 Jan 2022 07:28:23 GMT, Tobias Hartmann <thartmann at openjdk.org> wrote:
> > > > Tobias Holenstein has updated the pull request incrementally with one additional commit since the last revision:
> > > > Cleanup output of TraceDeoptimization
> > > 
> > > 
> > > src/hotspot/share/runtime/deoptimization.cpp line 1954:
> > > > 1952: #if INCLUDE_JVMCI
> > > > 1953:             , debug_id
> > > > 1954: #endif
> > > 
> > > 
> > > You can use `JVMCI_ONLY` here as well. Same in line 1840.
> > 
> > 
> > Unfortunately, because of the comma and the way JVMCI_ONLY is defined, this does not work. I will leave it as it is
> 
> We have the COMMA macro to solve that problem e.g.
> 
> ./share/runtime/threadSMR.inline.hpp: DEBUG_ONLY(COMMA _list(list))
> 
> Cheers, David

Ok, I didn't know that. I changed it now to  DEBUG_ONLY(COMMA ...)

Thanks David! 

- Tobias

-------------

PR: https://git.openjdk.java.net/jdk/pull/6746