RFR: 8248404: AArch64: Remove uses of long and unsigned long [v2]
Stefan Karlsson
stefank at openjdk.java.net
Tue Jan 11 16:04:06 UTC 2022
On Tue, 11 Jan 2022 15:25:31 GMT, Quan Anh Mai <duke at openjdk.java.net> wrote:
>> src/hotspot/cpu/aarch64/macroAssembler_aarch64_log.cpp line 300:
>>
>>> 298: fmovs(tmp3, vtmp5); // int intB0 = AS_INT_BITS(B);
>>> 299: mov(tmp5, 0x3FE0);
>>> 300: uint64_t mask = 0xffffe00000000000UL;
>>
>> I think this should be using ULL to support LLP64.
>
> Integral literal takes the first type that fits so for this 64-bit all suffices would produce the same type.
Thanks, I wasn't sure what would happen if you used the "wrong" suffix. I think it still makes sense to use the correct prefix for the intended target type.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7023
More information about the hotspot-dev
mailing list