RFR: 8248404: AArch64: Remove uses of long and unsigned long [v8]

Kim Barrett kbarrett at openjdk.java.net
Fri Jan 14 21:29:56 UTC 2022


On Wed, 12 Jan 2022 21:34:35 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 972:
>> 
>>> 970:  * Method entry for static native methods:
>>> 971:  *   int java.util.zip.CRC32.updateBytes(int crc, byte[] b, int off, int len)
>>> 972:  *   int java.util.zip.CRC32.updateByteBuffer(int crc, jlong buf, int off, int len)
>> 
>> Why not `int64_t` instead of `jlong`?   Similarly in a couple later places.
>
> This comment refers to Java code which more appropriately uses jlong.  Actually, the Java code uses long.  I'll revert this change.

Yeah, this is in a comment referring to a Java method signature, so I agree `long` is correct here.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list