RFR: 8248404: AArch64: Remove uses of long and unsigned long [v8]

Coleen Phillimore coleenp at openjdk.java.net
Mon Jan 17 16:32:07 UTC 2022


On Wed, 12 Jan 2022 21:33:28 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp line 1174:
>> 
>>> 1172:         assert(r->is_valid(), "bad oop arg");
>>> 1173:         if (r->is_stack()) {
>>> 1174:           __ ldr(temp_reg, Address(sp, (uint64_t)r->reg2stack() * VMRegImpl::stack_slot_size));
>> 
>> Why is the cast being added here?  Is it because the multiply can overflow an int, and this is really fix for a bug that is distinct from the cleanup in this PR?  There are a couple more like this later in this file.
>
> This was here to match one of the Address constructors that I had.  With the template, it's no longer needed.

I think I didn't revert this.  Retesting.

-------------

PR: https://git.openjdk.java.net/jdk/pull/7023


More information about the hotspot-dev mailing list