RFR: 8277948: AArch64: Print the correct native stack if -XX:+PreserveFramePointer when crash [v4]

Denghui Dong ddong at openjdk.java.net
Thu Jan 27 15:21:42 UTC 2022


On Thu, 27 Jan 2022 12:19:12 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Denghui Dong has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update copyright year
>
> src/hotspot/cpu/aarch64/frame_aarch64.cpp line 470:
> 
>> 468:   // in C2 code but it will have been pushed onto the stack. so we
>> 469:   // have to find it relative to the unextended sp
>> 470: 
> 
> The comment above this change needs to be updated to explain when and why it is correct to use 1) the unextended sp and frame size or 2) the sender sp.

Thanks. 
I changed the comment, but this seems cannot be clearly explained in one or two sentences.
Please feel free to give any advice to refine the comment.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6597


More information about the hotspot-dev mailing list