RFR: 8277948: AArch64: Print the correct native stack if -XX:+PreserveFramePointer when crash [v4]
Andrew Dinn
adinn at openjdk.java.net
Thu Jan 27 17:28:36 UTC 2022
On Thu, 27 Jan 2022 15:18:01 GMT, Denghui Dong <ddong at openjdk.org> wrote:
>> src/hotspot/cpu/aarch64/frame_aarch64.cpp line 470:
>>
>>> 468: // in C2 code but it will have been pushed onto the stack. so we
>>> 469: // have to find it relative to the unextended sp
>>> 470:
>>
>> The comment above this change needs to be updated to explain when and why it is correct to use 1) the unextended sp and frame size or 2) the sender sp.
>
> Thanks.
> I changed the comment, but this seems cannot be clearly explained in one or two sentences.
> Please feel free to give any advice to refine the comment.
Thanks. That's actually very clear and I don't think I can improve it.
-------------
PR: https://git.openjdk.java.net/jdk/pull/6597
More information about the hotspot-dev
mailing list