RFR: 8265473: Move os::Linux to its own header file [v4]

David Holmes dholmes at openjdk.org
Mon Jul 11 06:31:49 UTC 2022


On Mon, 11 Jul 2022 05:24:31 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renamed to os_linux_impl.hpp
>
> I like the idea of using namespaces. I think the private methods in os.hpp can be moved to share/runtime/osImpl.hpp, which should be included only by the os*.cpp files. Let me try to do a prototype of this.

@iklam I thought we very recently rejected use of namespaces due to the visibility issue? 

Call me old fashioned by I much prefer classes for defining interfaces.

-------------

PR: https://git.openjdk.org/jdk/pull/9423


More information about the hotspot-dev mailing list