RFR: 8289743: AArch64: Clean up patching logic [v9]

[Andrew Haley]

On Fri, 15 Jul 2022 16:25:00 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Andrew Haley has updated the pull request incrementally with three additional commits since the last revision:
>> 
>>  - 8289743: AArch64: Clean up patching logic
>>  - 8289743: AArch64: Clean up patching logic
>>  - 8289743: AArch64: Clean up patching logic
>
> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 304:
> 
>> 302:     ptrdiff_t offset = target - insn_addr;
>> 303:     if (inner) {
>> 304:       instructions = 2;
> 
> inner will always be non null so assert instead of branch?

It'll segfault anyway. I don't think we normally assert for such things, but I don't mind if you insist.

> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 313:
> 
>> 311:     }
>> 312:     // movk has handled the upper bits. Now we extract the lower 19
>> 313:     // bits of the signed offset field for the ADRP.
> 
> It's not always a movk though is it?

True, I'll reword it.

-------------

PR: https://git.openjdk.org/jdk/pull/9398