RFR: 8289743: AArch64: Clean up patching logic [v9]

[Andrew Dinn]

On Fri, 15 Jul 2022 16:41:34 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp line 304:
>> 
>>> 302:     ptrdiff_t offset = target - insn_addr;
>>> 303:     if (inner) {
>>> 304:       instructions = 2;
>> 
>> inner will always be non null so assert instead of branch?
>
> It'll segfault anyway. I don't think we normally assert for such things, but I don't mind if you insist.

The rationale for replacing the if with an assert was as much to clarify expectations as to guard against errors.

-------------

PR: https://git.openjdk.org/jdk/pull/9398